-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace max KSP version empty string with "any" in GUI #2420
Conversation
Replace empty strings for max KSP version with N/D
I guess I don't find this clearer. Users are going to wonder what the N and D stand for. |
Would N/A be better? |
Or "Unlimited" ? |
Unlimited is clearer, but kind of long. |
I might not get this right, but as I see #1866, the problem was with the mod-JSON parsing and handling "any" and NULL differently? |
Yes, I think in between we changed the display and sorting values for this column to different values. |
I do think "any" would be preferable to "N/D" (which I admit I am not instantly parsing, myself). Not defined? |
Yes, N/D stands for "Not Defined", but if we already have trouble understanding it, it's probably not a good idea. So, "any" now? |
If you can push a new commit with that change in the next 12 hours, I'll include it in the 1.25.1 release I'm going to put out in the morning. |
Done! |
Might I suggest that you make sure this works EXACTLY as the current KSP-AVC works (which I'm now maintaining)? Some bugs were fixed which might affect this |
Not saying this is wrong, just want to review it together |
This shouldn't affect AVC at all, since it just changes just the representation of an empty maxVersion string in the GUI. |
That's a completely different bit of code (assuming you're referring to the parsing of max KSP from .version files) |
empty to "any"? |
If there's no max KSP version defined in a mod's metadata, CKAN GUI displays it as an empty string.
See
It would be prettier and more informative if there is some text, so I changed the empty string to
"N/D""any".This applies to the lower right metadata box and also the column in the modlist, as you can see here: